robwalkerco / redux-persist-filesystem-storage

Redux persist adaptor for React Native filesystem storage
MIT License
196 stars 71 forks source link

Crash regarding rn-fetch-blob #48

Closed IhorDemedyuk closed 4 years ago

IhorDemedyuk commented 4 years ago

crash

Hi, Faced this issue after replaced AsyncStorage from '@react-native-community/async-storage' with FilesystemStorage from 'redux-persist-filesystem-storage'

Found that adding custom dependency to rn-fetch-blob v0.12.0 into project fixes the issue. Currently redux-persist-filesystem-storage uses rn-fetch-blob v0.10.16 Suppose library dependency upgrade will fix this without need to add separate rn-fetch-blob dependency.

therealemjy commented 4 years ago

Same issue here, thanks for providing the fix!

robwalkerco commented 4 years ago

Thanks for reporting the issue. Please open a PR with the suggested solution.

iqqmuT commented 4 years ago

I'm not sure but looks like commit 51fa5974abb0bbd85a9ae82cf1b597c1652328bb does not fix this issue. You have to install rn-fetch-blob and let auto linking do its job. The issue occurs if auto linking has not been made.

github-actions[bot] commented 4 years ago

This issue will be closed soon. Is it still a valid issue?