search

robwalkerco / redux-persist-filesystem-storage

Redux persist adaptor for React Native filesystem storage
MIT License
196 stars 71 forks source link

Use react-native-blob-util ^0.13.7 #56

Closed robwalkerco closed 3 years ago

robwalkerco commented 3 years ago

Switch to using react-native-blob-util

Closes #55

robwalkerco commented 3 years ago

@imranMnts I've setup the change in this PR.

I'd really appreciate if you are able to confirm that everything is good for me, by installing this branch and testing it your quickly in your app. (I'm not actually actively using this project right now)

You can install it by simply swapping the npm version in your package.json file with git+https://github.com/robwalkerco/redux-persist-filesystem-storage.git#813045c3ee14199a5a503e15c2148a40ba66998c, then running yarn or npm to update the dependancies.

imranMnts commented 3 years ago

@robwalkerco

It doesn't work, looks like you still use rn-fetch-blob in the code.

https://github.com/robwalkerco/redux-persist-filesystem-storage/blob/813045c3ee14199a5a503e15c2148a40ba66998c/index.js#L5

we have to use import ReactNativeBlobUtil from 'react-native-blob-util' with the new one.

robwalkerco commented 3 years ago

@imranMnts I've corrected the import.

It would be great if you could give it another try 🙏

imranMnts commented 3 years ago

I encountered this issue.. https://github.com/RonRadtke/react-native-blob-util/issues/33

github-actions[bot] commented 3 years ago

This pull request will be closed soon. Is it still a valid issue?

williamgurzoni commented 3 years ago

Hi, will it be merged?

midhunm-c commented 3 years ago

Hi, we have changed our app dependancy to RonRadtke/react-native-blob-util, so can we expect this to be merged soon? It would be very helpful if dependancy changed to react-native-blob-util. Thank you !!

robwalkerco commented 3 years ago

I'd really appreciate if a few users would be able to confirm that everything is good with this PR, by installing this branch and testing it your quickly in your app. (I'm not actually actively using this project right now). I would then be more confident to release this as version 4.0.0 on npm

You can install it by simply swapping the npm version in your package.json file with git+https://github.com/robwalkerco/redux-persist-filesystem-storage.git#22514a2ee00482ff3827a5da8f1722badbaac6d0, then running yarn or npm to update the dependencies.

midhunm-c commented 3 years ago

Hi @robwalkerco, I have checked from git+https://github.com/robwalkerco/redux-persist-filesystem-storage.git#22514a2ee00482ff3827a5da8f1722badbaac6d0 It's working fine for me with react-native-blob-util.