search

robwebdev / ember-cli-staticboot

MIT License
31 stars 6 forks source link

Ensure all assets are copied to destDir #12

Closed robwebdev closed 7 years ago

robwebdev commented 7 years ago
mike183 commented 7 years ago

Other than the comment above, it seems to be working well in my application.

robwebdev commented 7 years ago

Thanks for the input @mike183.

@limptwiglet could you take a look at this when you get chance?

limptwiglet commented 7 years ago

@robwebdev sorry mate didn't get a chance to commit this last night. Yeah looks all good to me.

robwebdev commented 7 years ago

@limptwiglet no probs! cheers

mike183 commented 7 years ago

This is working great, thanks for working on this! Any chance of cutting a new release?

Also, I noticed in this PR that the docs were changed to use ember build. Is there any difference in running ember staticboot vs ember build?

robwebdev commented 7 years ago

@mike183 No probs! I'll tag a release this evening.

The difference is that ember staticboot will serve the app, whilst ember build will just build it and not serve it. Really, I should have both in the readme. Are you using the staticboot command to serve the app?

mike183 commented 7 years ago

Awesome, thanks.

Currently, I've just been using ember serve to serve the application. The only time I used ember staticboot was at the beginning when I thought that was the only way to build the static output, but I stopped and started using ember build once I'd realised that worked as well. I've not really used ember staticboot since, should I be?

robwebdev commented 7 years ago

Others are using it in the same way as you are, that's totally fine and I don't see any problem with it.

I'll probably re-add the staticboot command to the readme once it has some test coverage and I can verify its working how I want it to. Currently its pretty much just a copy and paste of the ember fastboot command!

mike183 commented 7 years ago

Cool thanks.

If the ember staticboot command doesn't do anything special, wouldn't it be best to deprecate/remove it and tell users to just use the ember serve and ember build commands as they would usually? That way there is less code to maintain and users can just continue to use the EmberCLI commands that they're used to.

Obviously your add-on, your choice, just my two cents 👍

robwebdev commented 7 years ago

Well, ember staticboot aims to build and serve the static pages, which neither of the ootb commands will do just yet.