Re-implement includeClientScripts option

robwebdev / ember-cli-staticboot

MIT License

31 stars 6 forks source link

Re-implement includeClientScripts option #14

Closed mike183 closed 7 years ago

mike183 commented 7 years ago

This PR re-introduces and fixes the includeClientScripts option that was removed previously due to being broken.

As we don't require the generated static build to be a fully functioning ember application, it doesn't make sense for the client scripts to be included. Using this option actually reduces the page weight of our homepage by just under 75%!

mike183 commented 7 years ago

Just added a couple of extra assertions that test this functionality.

mike183 commented 7 years ago

Just committed some bug fixes that:

Fixed an issue where the client scripts were only being removed from the root index.html file
Fixed ember serve usage by ensuring that the client scripts were only removed from the static build

robwebdev commented 7 years ago

Awesome, thanks for bringing this back.