search

robwebdev / ember-cli-staticboot

MIT License
31 stars 6 forks source link

Avoid clobbering `this.options` #26

Closed mike183 closed 7 years ago

mike183 commented 7 years ago

Fixes a deprecation warning being emitted when using ember-cli-staticboot with EmberCLI 2.13.0.

Deprecation being thrown:

DEPRECATION: Ember CLI addons manage their own module transpilation during the `treeForAddon` processing. `ember-cli-staticboot` (found at `{PATH}/ember-cli-staticboot`) has overridden the `this.options.babel` options which conflicts with the addons ability to transpile its `addon/` files properly. Falling back to default babel configuration options.
robwebdev commented 7 years ago

Thanks!

mike183 commented 7 years ago

Thanks for merging! Any chance of a release that includes these changes?

robwebdev commented 7 years ago

@mike183 I'm having issues with the build at the moment and haven't had a chance to take a proper look. I will try this weekend and hopefully release.

robwebdev commented 7 years ago

@mike183 Sorry for the delay, I've just released this. https://github.com/robwebdev/ember-cli-staticboot/releases/tag/v0.1.4

mike183 commented 7 years ago

@robwebdev No worries, thanks for the heads up 👍