search

robwebdev / ember-cli-staticboot

MIT License
31 stars 6 forks source link

[WIP] update to latest fastboot #31

Closed tchak closed 6 years ago

tchak commented 7 years ago

WIP to upgrade to latest fastboot. Tests ara failing for now and it needs to wait for https://github.com/ember-fastboot/ember-cli-fastboot/pull/467 to be released

Closes #28 Closes #23

RobbieTheWagner commented 6 years ago

The fastboot PR was merged. Can we get this in?

tchak commented 6 years ago

@rwwagner90 this branch is in a working state now. I am still struggling with tests.

I also have not heard from @robwebdev yet. Rob if you are not interested in maintaining this anymore do you mind to transfer ownership? If not I guess I will fork and publish under another name.

robwebdev commented 6 years ago

Hey @tchak and @rwwagner90 . As you can tell I've been neglecting to maintain staticboot. I think it could be a really useful tool but just haven't had the time to see it through, so I'd be delighted if someone else would pick it up. I'm going to add you both as collaborators and after that we can discuss transferring ownership.

tchak commented 6 years ago

@robwebdev sounds good 👍 ❤️

RobbieTheWagner commented 6 years ago

@robwebdev @tchak would love to add you guys to my org, Ship Shape, and maintain it there with you both 😄 https://github.com/shipshapecode

RobbieTheWagner commented 6 years ago

@tchak any reason not to merge this?

tchak commented 6 years ago

the tests are still broken

RobbieTheWagner commented 6 years ago

@tchak oh, is this not setup on travis? I assumed it worked since it was green here.

RobbieTheWagner commented 6 years ago

@robwebdev can we get travis running here?

robwebdev commented 6 years ago

@rwwagner90 I have CircleCI set up for this repo, although the setting to build pull requests from forks was disabled. I turned that on last night with the hope it might kick in, but it might be the case that it will only happen to new PR's.

RobbieTheWagner commented 6 years ago

Ah okay. @tchak maybe you can push some sort of change and it will trigger the builds?

mike183 commented 6 years ago

Has there been any further progress with this PR?

RobbieTheWagner commented 6 years ago

@mike183 we've been waiting to hear back from @tchak on the review comments that @robwebdev left above. It's possible that will fix the test failures.

RobbieTheWagner commented 6 years ago

@tchak Bump!

tchak commented 6 years ago

Hey, sorry for silence. I stoped working on this because I started using https://github.com/ef4/prember that solved my use case. The README also have a reference that explain the difference between different addons in this space. https://github.com/ef4/prember#compared-to-other-addons