search

robwebdev / ember-cli-staticboot

MIT License
31 stars 6 forks source link

Add automatic route recognisation #6

Open robwebdev opened 7 years ago

robwebdev commented 7 years ago

If possible, staticboot should grab the paths from routes defined in the router and crawl those, removing the need to duplicate them in the config.

locks commented 7 years ago

I'll try to look into this soon. For routes with dynamic segments, I was thinking of defining the array of possible values, maybe? Have to play around with it.

robwebdev commented 7 years ago

@locks That would be awesome. The array idea matches what I had in mind. I hacked around on this branch, maybe that would be useful at least as a reference.

acorncom commented 7 years ago

Hey @robwebdev, appreciate your work here. @locks and I continue to have dreams of using this add-on in a variety of places (including the Ember guides). Was looking at what you have on your spike above and had a different idea for how we might get to the needed info. I wrote out high-level pseudo code on my branch (https://github.com/acorncom/ember-cli-staticboot/commit/17e2e9c2eeaab2bb97c1f54acf36972e5cd30e77) with the stuff of interest being here: https://github.com/acorncom/ember-cli-staticboot/blob/17e2e9c2eeaab2bb97c1f54acf36972e5cd30e77/lib/broccoli/staticboot.js#L43-L64

Do you guys think this might be a possibly option to pursue? Would love to get more eyes on it, as it looks like a lot of work to do ... 😀 The handler state we need to be able to call Router.generate() seems buried in there fairly deeply ...