search

robweber / cronxbmc

A simple Cron-like service for Kodi
MIT License
19 stars 19 forks source link

add to official kodi repo? #24

Closed TermeHansen closed 2 years ago

TermeHansen commented 2 years ago

Why is this addon not in the official kodi repo?

https://github.com/xbmc/repo-plugins/tree/matrix

robweber commented 2 years ago

Good question. I don't recall specifics but I believe there was a reason originally. The very first versions of this didn't even have a GUI and were pretty hard to configure. I think over time it's just gotten a lot more user friendly but I never revisited the idea of submitting it. It wouldn't take much to at least try and get it reviewed.

TermeHansen commented 2 years ago

No its fairly easy. Will you do it, or should I do it? I have a PR btw comming up with a fix for relative import in py3 as I would like to use this imy addon 🤓

robweber commented 2 years ago

I can prep stuff to get it ready to submit. I like to use Kodi's "auto submitter" tool so I'll cut/paste the workflow from one of my other addons. I'll watch for that PR and get that all worked out first before pushing to the Kodi repo. Thanks for the thoughts on this.

TermeHansen commented 2 years ago

https://github.com/robweber/cronxbmc/pull/25

robweber commented 2 years ago

I did some cleanup to get this ready for the main Kodi repo. Can you test the matrix branch? No big changes but I did mess with the settings file to make sure it adheres to the new format. Works on my side but two tests is better than one.

TermeHansen commented 2 years ago

Sure, I'll post when I have tested later today....

TermeHansen commented 2 years ago

Just tested latest from matrix branch, seems to work fine for my use also...

robweber commented 2 years ago

Just as an update - I didn't forget about this. I'm having issues the the Kodi addon submitter addon. After fighting with it for a while I decided to just do the PR by hand. I was all ready to submit this to the repo and right before I hit "submit" on the pull request I noticed the addon image still said "XBMC" in it. I'll have to fix it, re-tag, and prepare the PR again. Just wanted to let you know I didn't forget about this, just had some hassles.

TermeHansen commented 2 years ago

Any news? I have branch waiting for it 🤓

robweber commented 2 years ago

I just updated the logo to remove the XBMC reference. I'll re-do the tag and submit.

robweber commented 2 years ago

Pull request: https://github.com/xbmc/repo-scripts/pull/2272

robweber commented 2 years ago

Looks like this is good. Thanks for the additions and the comment on the PR pushing this through. I always hesitate to bug the Kodi devs too much, I know reviewing the addons takes time and probably not a fun task.

TermeHansen commented 2 years ago

Yes me 2, but also it's hard to know if he waits for me/you to say it is ready for review again...

Feel free to ping me if you need help with PR or tests of kodi addons....