robweber / xbmcbackup

Backup Addon for Kodi
MIT License
107 stars 48 forks source link

Unable to add Remote Path #193

Closed CiNcH83 closed 3 years ago

CiNcH83 commented 3 years ago

Describe the problem When trying to add a path, the browser lacks several entries, like for example Zerconf browser or Add network location...: image

In Kodi's own File manager, those entries are available: image

This makes the addon pretty much unusable for me as I can't find a way to add a network path as SMB shares can only be added via Zeroconf browser on Android.

Platform and Kodi version Android TV 9 Kodi 19.1 Backup 1.6.7

Tell me whether a log will help.

CiNcH83 commented 3 years ago

Now worked around it by sharing the folder via insecure NFS.

robweber commented 3 years ago

You couldn't select "Windows network (SMB)" and browse for the share? The naming is confusing (this is Kodi's dialog, not mine) but that entry means any SMB share; no matter the hosting source. You should be able to select that and browse from there. Add Network Location is missing as this dialog isn't for adding anything as a source for video/music. You'll need to browse to the path and then hit OK to fill in the path name. If I'm not following this right please let me know.

If Zeroconf is your only option for Android related to browsing could you use the "type path" option and just type the full path that way "smb://......"?

CiNcH83 commented 3 years ago

You couldn't select "Windows network (SMB)" and browse for the share?

No. That doesn't work on Android, also see here.

If Zeroconf is your only option for Android related to browsing could you use the "type path" option and just type the full path that way "smb://......"?

Would have to try this. Why is there no Zeroconf browser available for the addon?

I think I will stay with NFS. I can publish the Kodi backup shared folder without putting other data at risk.

robweber commented 3 years ago

Interesting - I don't use SMB myself so didn't realize the browse option only worked for SMBv1. Makes sense.

I am at a loss about why Zeroconf browser doesn't show up. I'm not coding anything to do with the file browser, I'm simply asking Kodi to launch one. It could be that the internal components of Kodi just aren't allowing it to appear. Issues with this in the past are what lead to the "type path" option being available. Cross platform solutions for network service browsing aren't always reliable.

One thing I did try that seemed to work was adding the <source>files</source> tag to the path option. This doesn't add the Zeroconf browser but it does bring in any saved paths from the File Manager to the root nav. You could use the File Manager to add the path you want and then it would appear in Backup browser as a selectable source. I think this could be a workable solution.

CiNcH83 commented 3 years ago

Zeroconf browser has always worked for me with Backup. Only now with 19.1 and 1.6.7 it does not anymore. Thought the problem might be similar to this.

robweber commented 3 years ago

I couldn't find any combination of the local, programs, video, etc options that put it back. Either something with the new settings system or just removed with Kodi 19. It definitely exists in the "Add Source" option but not in the addon file browser. I think adding it as a source for the File Manager is a good workaround - or at least the best we can do for now.

CiNcH83 commented 3 years ago

I tested the workaround and it seems to work. The browser shows NFS and SMB paths after having been added through File manager. It however does not show FTP paths for some reason.

(I now decided against using NFS for Backup as it contains username and password of my NAS in clear text. SMB works with the workaround.)