search

robweber / xbmclibraryautoupdate

Kodi Addon to update your video/music libraries on a schedule
MIT License
30 stars 22 forks source link

Submit to repo-script matrix branch? #54

Closed phunkyfish closed 4 years ago

phunkyfish commented 4 years ago

Hey Rob,

Firstly, thanks for the addon, it's well used in my house ;)

Can I ask when when you plan to submit it to the repo-scripts matrix (py3) branch?

robweber commented 4 years ago

Thanks - glad you're getting use out of it!

Have you tried the matrix nightlies and it's not there? The version in the Leia branch is both python 2 and 3 compatible so I guess I was hoping it would just translate to Matrix. Normally as long as the addon is compatible it will work with version forward of Kodi. If this isn't the case let me know and I'll do a separate PR for Matrix. I haven't tried a nightly in a while, just when I was working on the Python 3 compatibility, the repo wasn't ready yet at that time.

phunkyfish commented 4 years ago

Ya, it needs to be submitted separately to the matrix branch.

I believe it’s Leia and below and then Matrix and above is the cutoff.

Thanks!

On 9 Mar 2020, at 13:05, Rob notifications@github.com wrote:

 Thanks - glad you're getting use out of it!

Have you tried the matrix nightlies and it's not there? The version in the Leia branch is both python 2 and 3 compatible so I guess I was hoping it would just translate to Matrix. Normally as long as the addon is compatible it will work with version forward of Kodi. If this isn't the case let me know and I'll do a separate PR for Matrix. I haven't tried a nightly in a while, just when I was working on the Python 3 compatibility, the repo wasn't ready yet at that time.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

robweber commented 4 years ago

Good to know. I thought the whole point of making the addons both python 2 and 3 compatible was that they'd filter up if they work on Leia.

I'll get this done ASAP. It's basically ready so just need to get a PR going. Thanks for pointing this out.

phunkyfish commented 4 years ago

Any luck with that PR?

Would like to soak test some Matrix stuff, will start that once this PR is in 😉

robweber commented 4 years ago

Sorry, our area went nuts due to COVID-19 so been busy with that. Canceled schools, stuff like that which affected the day to day.

I'll get to it either tonight or tomorrow though. Starting to find a rhythm again.

phunkyfish commented 4 years ago

Don’t worry about it. I completely understand. It’s a trying time for everyone.

robweber commented 4 years ago

Got a nightly of Matrix running on a demo PC. I'm running through a few addon update cycles to make sure all dependencies and things work as expected. If there aren't any issues I'll get PR going yet today.

phunkyfish commented 4 years ago

Amazing, thanks!

robweber commented 4 years ago

Merged - https://github.com/xbmc/repo-scripts/pull/1358

phunkyfish commented 4 years ago

Thanks so much!