search

robweber / xbmclibraryautoupdate

Kodi Addon to update your video/music libraries on a schedule
MIT License
30 stars 22 forks source link

use a proper connectivity check instead of google.com #71

Closed afontenot closed 1 year ago

afontenot commented 1 year ago

libraryautoupdate performs a connectivity check before scanning the library. Previously, this check fetched www.google.com, which is inappropriate for a connection check.

This commit fixes the problem by fetching a static connectivity check page, which returns a 204 status code with an empty response.

Note: I bumped the version to 1.2.5 because after the merge this repo contains changes that differ from the upstream Kodi release. Maybe you want to fix this a different way, but it seemed like the most obvious choice would be to bring everything back into sync once you decide to release 1.2.5.

afontenot commented 1 year ago

Actually, maybe you want to rebase your changes on a new branch first? Not sure if you want to force push to this one as part of cleanup or not.

robweber commented 1 year ago

For such a small revision I'm not going to think about it too much! This can be merged in without conflicts so easiest to just do that and get everything event with what's in the Kodi repo. Thanks for the patch!