Closed carols10cents closed 10 years ago
Ha, I see how that could be confusing. Build control fails no matter what if you have a dirty working directory and 'connect-commits' set to true. The --force you're seeing is from grunt — any time a grunt task fails you'll get that message and the ability to skip the failing grunt task.
On Tuesday, December 17, 2013, Carol Nichols wrote:
What happened:
I (and by "I" I mean @bobthebotmaker https://github.com/bobthebotmaker) had local uncommitted changes and tried to invoke grunt-build-control.
I then got the warning:
Running "buildcontrol:lab" (buildcontrol) task Warning: There are uncommitted changes in your working directory. Please commit changes to the main project before you commit to the built code. Use --force to continue.
I was actually testing changes to the Gruntfile, so I didn't want to commit the changes yet because we hadn't verified them by running this command. :ouroboros: So I said, ok, fine, I'll just use --force to get past this warning like it says I can.
But using --force causes buildcontrol to fail:
Running "buildcontrol:lab" (buildcontrol) task Warning: There are uncommitted changes in your working directory. Please commit changes to the main project before you commit to the built code. Used --force, continuing. Warning: Task "buildcontrol:lab" failed. Used --force, continuing.
If you're not allowed to build with uncommitted files, which seems to be the case, then this should be an error rather than a warning right? Either that or not offering --force as a way to get around this, if that's possible, would be better imo.
[image: no_power_here_lotr]https://f.cloud.github.com/assets/193874/1765173/200537f2-6732-11e3-91a2-0e9a4fa778d6.gif
— Reply to this email directly or view it on GitHubhttps://github.com/robwierzbowski/grunt-build-control/issues/13 .
Rob Wierzbowski @robwierzbowski http://twitter.com/#!/robwierzbowski http://github.com/robwierzbowski http://robwierzbowski.com
If you want to deploy something without a clean working directory, set the connectCommits
option to false. See the readme for more info.
What happened:
I (and by "I" I mean @bobthebotmaker) had local uncommitted changes and tried to invoke grunt-build-control.
I then got the warning:
I was actually testing changes to the Gruntfile, so I didn't want to commit the changes yet because we hadn't verified them by running this command. :ouroboros: So I said, ok, fine, I'll just use
--force
to get past this warning like it says I can.But using
--force
causes buildcontrol to fail:If you're not allowed to build with uncommitted files, which seems to be the case, then this should be an error rather than a warning right? Either that or not offering
--force
as a way to get around this, if that's possible, would be better imo.