robwierzbowski / grunt-build-control

Version control your built code.
MIT License
380 stars 36 forks source link

Write tests! #19

Open robwierzbowski opened 10 years ago

robwierzbowski commented 10 years ago

This module needs some tests something fierce.

robwierzbowski commented 10 years ago

I don't think there's much value in unit testing this package, since the commands it uses are pretty close to the metal and refactoring is likely to involve different workflows with different git commands. Integration tests are very much needed though.

Test coverage we need:

kevinawoo commented 10 years ago

I wasn't sure there was any way to run tests that existed in the repo, as they seem to be just place holders, thus I made tests run as scenarios. Check it out on https://github.com/kevinawoo/grunt-build-control/compare/robwierzbowski:master...feature/tests

Let me know what you think, I'm going to be writing more tests in this style as it was easiest for me to understand.

zetorama commented 9 years ago

I've just forked the project, but i'm not able to perform simple grunt jshint. Seem to be some wrong configs in Gruntfile.js:

Loading "nodeunit.js" tasks...ERROR
>> Error: No such module: evals

Running "jshint:all" (jshint) task
Warning: An error occurred while processing a template (Cannot read property 'tests' of undefined)

So, it's totally unclear, if I should respect jshint & tests, while going to make a PR. Should I?

kevinawoo commented 9 years ago

Ah, yes. I'll need to fix the tests and make some changes to .jshint

For now, you can ignore grunt jshint