robwierzbowski / grunt-build-control

Version control your built code.
MIT License
380 stars 36 forks source link

Add support for using existing named remotes #25

Closed DaftMonk closed 9 years ago

DaftMonk commented 10 years ago

I wanted to add some tests to check the regex, but I couldn't get the grunt test task to run locally. That said, I tried the regex against a number of possible names to make sure it worked.

No matches

origin weird$1+name remote_name remote_name_extended remote-name remote.test

Matches

/path/to/repo.git/ path/to/repo.git/ /path/to/repo \path\to\repo path/to/repo C:/user/repo file:///path/to/repo.git/ git://git.com/~user/path/to/repo.git/ http://git.com/path/to/repo.git/ https://github.com/user/repo ssh://user@server/project.git user@server:project.git

closes #24

robwierzbowski commented 10 years ago

Looking good, but I'm going to work on tests before I merge anything new into the package. It might be a while before I get them finished, need to get settled on other tasks at work first. I'll ping as soon as they're merged.

JaKXz commented 10 years ago

Any update on this?

robwierzbowski commented 10 years ago

I haven't had the time to write tests yet. Work + other OSS is still higher on the list. A co-maintainer would certainly help.

meeDamian commented 10 years ago

+1 for merge

robwierzbowski commented 10 years ago

Add docs and I'll merge.

paulodiovani commented 9 years ago

+1 to merge. Works better with named remotes.

kevinawoo commented 9 years ago

I've just been added as a maintainer, will merge!