search

robyf / google-chat-linux

An unofficial desktop client for Google Hangouts Chat
37 stars 24 forks source link

Use higher resolution image for default app icon #9

Open rhymefororange opened 6 years ago

rhymefororange commented 6 years ago

The default app icon is very small(16x16) and therefore looks very pixelated. How it looks in the menu: image How it looks in the dock(with settings icon for reference): image

I propose to make a default icon at least 256x256. Besides, you already have the icon here: https://github.com/robyf/google-chat-linux/blob/master/assets/icon/chat-favicon-no-new-256dp.png

squalou commented 6 years ago

I had the same issue, in the archlinux package I simply replaced the provided one by the other one you suggest, so I guess it's a debian packaging tweak to do ?

rhymefororange commented 6 years ago

Probably yes. Just changing the default icon should do it.

rhymefororange commented 6 years ago

Any updates on this? Sorry if I'm too annoying, I understand this is low priority.

robyf commented 6 years ago

I'm currently on my summer break so I'm not going to work on this for a while. PRs are anyway welcome! ;)

By the way, out of curiosity what window manager do you use?

rhymefororange commented 6 years ago

Hi, I use Gnome 3.22.2 as a desktop environment with gdm3 (version 3.22.3 for some reason).

I'm not really sure how to fix this by myself other than replacing https://github.com/robyf/google-chat-linux/blob/master/assets/icon/icon.png with https://github.com/robyf/google-chat-linux/blob/master/assets/icon/chat-favicon-no-new-256dp.png, because I don't have much experience in packaging and electron.

Have a nice summer break.

Chelsea31 commented 6 years ago

Hi, I use Gnome 3.22.2 as a desktop environment with gdm3 (version 3.22.3 for some reason).

I'm not really sure how to fix this by myself other than replacing https://github.com/robyf/google-chat-linux/blob/master/assets/icon/icon.png with https://github.com/robyf/google-chat-linux/blob/master/assets/icon/chat-favicon-no-new-256dp.png, because I don't have much experience in packaging and electron.

Have a nice summer break.

When you rename the icons, you can then run npm run-script build and build the app, your new app is good to go

EDIT: By rename I mean, you can rename the file chat-favicon-no-new-256dp.png to icon.png, and the previous icon.png to something else

rhymefororange commented 6 years ago

Ok, but I don't do any work with npm so I don't have it installed and would like to install it from deb file like I did the previous version. If someone could repackage the deb file - that would be awesome.

rhymefororange commented 6 years ago

https://github.com/robyf/google-chat-linux/pull/11 addresses exactly this and needs merging.