search

roc-lang / basic-cli

A basic Command-Line Interface platform
Universal Permissive License v1.0
88 stars 30 forks source link

EnvDecoding type matches changes to decoding from here: https://github.com/roc-lang/roc/pull/6587 #176

Closed faldor20 closed 6 months ago

faldor20 commented 7 months ago

This PR for optional record field decoding changes the type of the finalize function to take two args: https://github.com/roc-lang/roc/pull/6587 This updates the signature to match

Anton-4 commented 6 months ago

@faldor20 I had to undo your change to the type signature of envTuple and change the signature of envRecord instead due to type mismatches. Can you confirm this is correct? Nix is using your Roc branch btw.

faldor20 commented 6 months ago

I have no idea how I missed that. So sorry. That's correct @Anton-4

Anton-4 commented 6 months ago

:+1: No problem