Refactor host files into crates

roc-lang / basic-webserver

A basic webserver in Roc

https://roc-lang.github.io/basic-webserver/

Universal Permissive License v1.0

76 stars 16 forks source link

Refactor host files into crates #54

Closed lukewilliamboswell closed 3 months ago

lukewilliamboswell commented 5 months ago

This PR separates the rust host files from the roc platform files, and adds a build.roc script.

The purpose of this change is to simplify the build process, and to have a clearer separation between these elements as this repository serves as an example of roc platforms.

lukewilliamboswell commented 4 months ago

Updated with changes to support the List refcounting performance fix.
Refactored Http to align closer to basic-cli and remove the glue generated types. Added roc_http and refactored the roc_host crate.
Fixed up and simplified the glue generation. Moved the glue-get.sh script to top level so it is easier to discover. The generated code still requires some manual clean-up but this is much simpler now.
Also includes a manual impl<T, E> RocRefcounted for RocResult<T, E> in roc_std that needs to be added into roc-lang/roc/crates/roc_std

Anton-4 commented 3 months ago

Looks like some of these are used...

bhansconnect commented 3 months ago

Looks like some of these are used...

Oh, I know whats happening. They type is being used in a RocResult. Which does use the refcounting impl. But still, the actual impl won't be called unless eventually the type is used in a list.

bhansconnect commented 3 months ago

So they are unused, but referenced by RocResult. So they can't be deleted.