search

roc-lang / book-of-examples

Software Design by Example in Roc
Other
23 stars 15 forks source link

Pattern Matching WIP #60

Closed stuarth closed 2 weeks ago

stuarth commented 3 weeks ago

Feedback welcome!

This chapter covers building a simple regular expression pattern matcher, a la https://third-bit.com/sdxjs/pattern-matching/

isaacvando commented 3 weeks ago

@stuarth This is great! I was not expecting the code to be so short and elegant; very cool. The prose is also clear and easy to understand. Can't wait to read the full chapter! 😄

It seems like there could be space to implement more regex features if it makes sense for the chapter.

stuarth commented 3 weeks ago

@stuarth This is great! I was not expecting the code to be so short and elegant; very cool. The prose is also clear and easy to understand. Can't wait to read the full chapter! 😄

It seems like there could be space to implement more regex features if it makes sense for the chapter.

really appreciate the review, thanks @isaacvando !

gvwilson commented 2 weeks ago

@stuarth can I please merge this as-is so that I can start work on ordering chapters?

stuarth commented 2 weeks ago

@stuarth can I please merge this as-is so that I can start work on ordering chapters?

Yep, go for it @gvwilson . Would appreciate any feedback on on the content as well