Require review from other code owner

roc-lang / rbt

Roc Build Tool

Universal Permissive License v1.0

49 stars 5 forks source link

Require review from other code owner #12

Open Anton-4 opened 3 years ago

Anton-4 commented 3 years ago

The way to go seems to be to:

[ ] set up CODEOWNERS
[ ] require one review for the trunk branch
[ ] require reviews from CODEOWNERS

The CODEOWNERS file should be set up to have at least two trusted contributors as code owners per folder. That way every PR will be reviewed by a (different) trusted contributor.

[ ] Verify settings by trying to merge PR with review from someone who is not a code owner.

BrianHicks commented 2 years ago

I'd like to set up a group like @roc-lang/rbt-reviewers for this. @rtfeldman what do you think? Based on activity so far, it'd maybe be you, me, and @bhansconnect?

BrianHicks commented 2 years ago

ping @rtfeldman! I'm about to open another PR assigning basically this group. Would it make sense or shall we skip it?

rtfeldman commented 2 years ago

rbt-reviewers sounds good! 👍

BrianHicks commented 2 years ago

Would you mind creating that group? I can set CODEOWNERS up afterwards but I am not a member of the roc-lang org with sufficient permissions to make a group.