search

roc-lang / rbt

Roc Build Tool
Universal Permissive License v1.0
49 stars 5 forks source link

walk the build graph in parallel #82

Closed BrianHicks closed 1 year ago

BrianHicks commented 2 years ago

This makes Coordinator walk the build graph in parallel.

After some discussion on Zulip, I did this with async Rust instead of spawning threads directly. I think this could still use some improvement, but it works well for now. We can tune it with tokio-console or something soon!

BrianHicks commented 2 years ago

@roc-lang/rbt-reviewers I'm requesting review of this since it seems like a configuration failure in CI. The tests all work locally, and the lints all pass in CI. 👍

bhansconnect commented 2 years ago

You should be able to use roc gen-stub-lib some-example-app.roc on nightly now to work around the build issues here.

Just run it before cargo test

BrianHicks commented 1 year ago

amazing, thank you!

BrianHicks commented 1 year ago

@bhansconnect any idea what could be going on here? Looks like we're generating libapp.so correctly, but then cargo test complains it can't be found. Is it looking somewhere other than in the current directory, do you think? https://github.com/roc-lang/rbt/actions/runs/3374554604/jobs/5600303279

BrianHicks commented 1 year ago

ok, monkeyed around with LD_LIBRARY_PATH. Now it's saying this:

/home/runner/work/rbt/rbt/target/release/deps/host-e02e8b3c7e864cef: error while loading shared libraries: ./libapp.so: ELF file's phentsize not the expected size