Empty out environment before running a job

roc-lang / rbt

Roc Build Tool

Universal Permissive License v1.0

49 stars 5 forks source link

Empty out environment before running a job #83

Closed celsobonutti closed 1 year ago

celsobonutti commented 2 years ago

This PR cleans up the environment variables before running a job, which fixes #63. For now, we're keeping the HOME as suggested in the comment. Some of the env vars are created when we run a shell command, like SHLVL, PWD and _, so they're also expected to be present.

celsobonutti commented 2 years ago

@BrianHicks I've opened the PR but GH won't let me assign a reviewer, so I'm pinging you 😅

BrianHicks commented 2 years ago

for CI:

the macos failure is a flake. The binary changed locations remotely. You can cherry-pick 6d45a32cd857ff9400de9446a2237666dbf97004 to fix it
the formatting check is real; you'll need to follow the steps mentioned in the output to fix it
I'm not sure about the Linux build. GitHub actions cancels jobs for one OS if another OS fails. Unhelpful. Surely there's a way to fix it but for now you'll need to get macos and formatters running before we can get feedback on Linux.