ADR #10: log handling - Githubissues

roc-lang / rbt

Roc Build Tool

Universal Permissive License v1.0

49 stars 5 forks source link

ADR #10: log handling #87

Closed BrianHicks closed 1 year ago

BrianHicks commented 1 year ago

I've been trying to think through how we handle logs. We have a couple different cases we need to handle. I think it needs a little more structure than we have right now, so here's an ADR to talk about that.

I'd like feedback on:

other than CLI/UI streaming, where else would it make sense to stream logs?
are there any cases in which collecting all the logs for an invocation wouldn't make sense?

BrianHicks commented 1 year ago

@rtfeldman I intended to talk with you briefly about this during our pairing today. But, since we had to cancel, would you just mind having a look sometime this week?

BrianHicks commented 1 year ago

@rtfeldman not to poke too much but… any feedback on this approach? I'd love to get started but I don't wanna be the only one who knows what's even going on with the implementation 😆

BrianHicks commented 1 year ago

@bhansconnect reading your comments through again, I reworded this ADR to make it clearer that we're talking about job logs (e.g. stdout and stderr), not logs from rbt. Does it make more sense in that light?