roc-lang / roc

A fast, friendly, functional language.
https://roc-lang.org
Universal Permissive License v1.0
4.46k stars 313 forks source link

fix slice refcounting mistakes that can modify data before a list #6911

Closed bhansconnect closed 4 months ago

bhansconnect commented 4 months ago

So when working with the new basic-cli mmap function, I realized that it could cause segfaults and was very confused. Turns out we had a few lingering seamless slice bugs.

Verified this functionality is correct using lldb and my mmap example from basic-cli.