roc-streaming / openfec

Unofficial OpenFEC fork with various bugfixes.
https://openfec.inrialpes.fr
Other
14 stars 11 forks source link

Fix build for big-endian targets #2

Closed viccie30 closed 1 year ago

viccie30 commented 2 years ago

The unrolled loops in the Reed-Solomon code were wrong for big-endian targets. I added a compile-time test in CMake and ifdefs in the code. I've tested the changes using sbuild and qemu-user-static on Debian s390x (big-endian, 64-bit) and powerpc (big-endian, 32-bit). Both work and so do little-endian amd64 and i386.

yarda commented 2 years ago

I can confirm it fixes tests on s390x.

gavv commented 1 year ago

Thank you!

gavv commented 1 year ago

Tagged v1.4.2.5 with this fix included.