search

roc-streaming / openfec

Unofficial OpenFEC fork with various bugfixes.
https://openfec.inrialpes.fr
Other
13 stars 11 forks source link

Fix install location of pkgconfig file #21

Closed daissi closed 1 month ago

daissi commented 1 month ago

This file contains architecture specific dir (for instance on x86_64 : libdir=/usr/lib/x86_64-linux-gnu), so it needs to be installed in a multi-arch path. This patch is applied in the debian package.

gavv commented 1 month ago

Thanks!

Can we use CMAKE_INSTALL_FULL_LIBDIR instead of CMAKE_INSTALL_LIBDIR for consistency with the rest cmake scripts?

gavv commented 1 month ago

I've changed it to CMAKE_INSTALL_FULL_LIBDIR, but let me know if we need to revert it.

gavv commented 1 month ago

Tagged new release: https://github.com/roc-streaming/openfec/releases/tag/v1.4.2.11

daissi commented 1 month ago

I've changed it to CMAKE_INSTALL_FULL_LIBDIR, but let me know if we need to revert it.

Thanks! It works too!