search

roc-streaming / openfec

Unofficial OpenFEC fork with various bugfixes.
https://openfec.inrialpes.fr
Other
13 stars 11 forks source link

Debian package fixes #7

Closed gavv closed 1 year ago

gavv commented 1 year ago

Minor issues with debian packages implemented in #5.

viccie30 commented 1 year ago

I can give this a go if you'd like?

gavv commented 1 year ago

Awesome, thanks!

viccie30 commented 1 year ago

Looking at Debian bug #1002724, it seems that @dankamongmen might also be interested in this.

dankamongmen commented 1 year ago

yeah, i had been planning on packaging this up (see https://github.com/roc-streaming/openfec/pull/4#event-7896282501), but if you already got to it, godspeed

viccie30 commented 1 year ago

I don't use openfec and/or roc-toolkit myself (anymore), but I had packaged both some time ago. If you actually use both, I'd be happy to give the packaging code to you or co-maintain it with you, whichever you prefer.

dankamongmen commented 1 year ago

I don't use openfec and/or roc-toolkit myself (anymore), but I had packaged both some time ago. If you actually use both, I'd be happy to give the packaging code to you or co-maintain it with you, whichever you prefer.

are you a DD? if so, i'm happy to comaintain, or maintain myself, or leave it to you. if not, and you'd like to become one, i'd be happy to sponsor your upload. i didn't mean to assert any claim to territory, just to let you know i've done some work here too =]. i've got packaging for it somewhere around here, but i doubt there's much difference between ours. have you pushed to salsa?

dankamongmen@gmail.com if you'd like to take this to email (either way is fine for me).

viccie30 commented 1 year ago

I have a draft version for inclusion in Debian at https://salsa.debian.org/viccie30/openfec. Getting it uploaded to Debian depends at the very least on the resolution of #9.

gavv commented 1 year ago

I've edited the first sub-task in the issue:

[...] and tags from 1.2.3 to v1.2.3

twojstaryzdomu commented 1 year ago

I'll try to answer those one by one:

On the item

Rename releases from openfec_1.2.3 to v1.2.3 and tags from 1.2.3 to v1.2.3

@gavv, have you tried editing the variable tag_name and setting release_name with to v${VERSION} and ${PACKAGE}_v${VERSION}?

gavv commented 1 year ago

@gavv, have you tried editing the variable tag_name and setting release_name with to v${VERSION} and ${PACKAGE}_v${VERSION}?

Nope, I didn't try it. I guess it's what we need.

twojstaryzdomu commented 1 year ago

Please let me know if it worked. As for the other items, these need to be checked if they do not break a subsequent roc-toolkit build (especially the inclusion of C files), some choices may have be intentional. I will reply shortly.

gavv commented 1 year ago

@twojstaryzdomu Thanks, your suggestion helped!

@viccie30 I've marked Rename releases from openfec_1.2.3 to v1.2.3 and tags from 1.2.3 to v1.2.3 as complete. See b452e08e5bb135c9fac541ce7553b7b60ceb8119

@twojstaryzdomu Regarding C files: I believe roc doesn't need them, it needs only headers.

gavv commented 1 year ago

Hi, I've fixed the remaining issues and tagged v1.4.2.7

gavv commented 1 year ago

@dankamongmen @viccie30 FYI: both openfec and roc-toolkit now build debian packages on release and attach them to release assets.

In case you would like to reuse debian/ directory from the repo, and need some adjustments, feel free to ping me.