roc-streaming / roc-go

Golang bindings for Roc Toolkit.
https://roc-streaming.org
MIT License
22 stars 10 forks source link

Tag release script #107

Closed ortex closed 1 year ago

ortex commented 1 year ago

106

➜  roc-go git:(main) ✗ ./tag.py 0.1111
Error: version "0.1111" is not in correct format
➜  roc-go git:(main) ✗ ./tag.py 0.2.1        
Error: tag "v0.2.1" already exists
➜  roc-go git:(main) ✗ ./tag.py --push ortex 0.2.2
[main 51d8c36] Release 0.2.2
 1 file changed, 1 insertion(+), 1 deletion(-)
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 10 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 348 bytes | 348.00 KiB/s, done.
Total 4 (delta 3), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (3/3), completed with 3 local objects.
To github.com:ortex/roc-go.git
   0df41a5..51d8c36  HEAD -> main
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:ortex/roc-go.git
 * [new tag]         v0.2.2 -> v0.2.2
Successfully released v0.2.2

result: https://github.com/ortex/roc-go/commit/51d8c36e136d193ccb4310517af2352acc2182de

coveralls commented 1 year ago

Coverage Status

coverage: 94.878%. remained the same when pulling c34723501f7d551dd29a2755e60e8db20fcdc16e on tag-release into 0df41a55c86ac72b10cd3b8039b7c5517d073538 on main.

gavv commented 1 year ago

Suggestions:

gavv commented 1 year ago

Ideally we also need "-f" option that will forcibly override tag both locally and remotely. We can add it in this pr or create a separate issue.

gavv commented 1 year ago

It also would be convenient to automatically change directory to project root at start, to allow invocation from any directory. I think we can assume that the script is in project root and chdir to script's dir.

ortex commented 1 year ago

fixed everything except "-f" option

gavv commented 1 year ago

LGTM!

gavv commented 1 year ago

https://github.com/roc-streaming/roc-go/issues/108