search

roc-streaming / roc-go

Golang bindings for Roc Toolkit.
https://roc-streaming.org
MIT License
21 stars 10 forks source link

Add error handling to go2cStr #50

Closed gavv closed 1 year ago

gavv commented 1 year ago

Currently, if go2cStr meets zero byte in the middle or in the end of the string, it stops early (and also oddly produces two zero bytes instead of one).

Instead, it should report error that the input string is incorrect. Everywhere where we call go2cStr, we should check error and report it to user.

PiotrLewandowski323 commented 1 year ago

Hi, I'd like to work on this issue.

gavv commented 1 year ago

@PiotrLewandowski323 thanks!

But we should wait until #49 is merged (I think it'll happen soon)

@ortex FYI

gavv commented 1 year ago

@PiotrLewandowski323 #49 is merged now!