roc-streaming / roc-go

Golang bindings for Roc Toolkit.
https://roc-streaming.org
MIT License
21 stars 10 forks source link

Add version information to API #61

Closed dhanusaputra closed 1 year ago

dhanusaputra commented 1 year ago

close #47

coveralls commented 1 year ago

Coverage Status

Coverage: 78.276% (+1.1%) from 77.127% when pulling 2ca9f89c30f579deb37af77e43a195a6559b1ce8 on dhanusaputra:add-version-info into ee4158d3a0370defea1197a6008293c8d764a2a0 on roc-streaming:main.

gavv commented 1 year ago

BTW welcome to matrix chat! https://roc-streaming.org/toolkit/docs/about_project/contacts.html

Asalle commented 1 year ago

Amazing job! It would make it even better if you included some motivation / closes #XX in the commit message to document it a bit more.

gavv commented 1 year ago

Added 3 minor comments, otherwise looks fine. Waiting for review from Asa.