[52]:... Test for log message struct

roc-streaming / roc-go

Golang bindings for Roc Toolkit.

https://roc-streaming.org

MIT License

22 stars 10 forks source link

[52]:... Test for log message struct #73

Closed Darrellbor closed 1 year ago

Darrellbor commented 1 year ago

PR for #52 Implemented TestLog_Message and check messages for

[x] Module
[x] Line
[x] File
[x] Time
[x] Pid
[x] Tid
[x] Text

Darrellbor commented 1 year ago

@gavv PR ready for review

coveralls commented 1 year ago

Coverage: 88.51% (+0.5%) from 87.971% when pulling f1d4f286b1952fcab79453a12926f43565462077 on Darrellbor:52-test_for_log_message_struct into ec43d2b9305b103ec0cb5e3169e8d7da618f9cde on roc-streaming:main.

gavv commented 1 year ago

@gavv PR ready for review

Thanks for PR! You can cast @roc-streaming/go instead of me because there are others who can review PRs too.

Darrellbor commented 1 year ago

oh ok noted

Darrellbor commented 1 year ago

@roc-streaming/go ready for re-review

gavv commented 1 year ago

Thanks!