Commit of "Use time.Duration for time intervals"

[g41797]

Done according to former issue #83

[coveralls]

Coverage: 92.687% (-1.4%) from 94.04% when pulling 160a174b3e29665b2952456518277875e2d5b513 on g41797:main into 9647d5d8bb3496fdbdaf49268f72475b24ebcff6 on roc-streaming:main.

[gavv]

@g41797 FYI:

• please don't resolve any discussions by yourself, it's done by reviewer; this way reviewer can track what need to be re-reviewed again; to indicate that discussion is addressed, you can leave a comment or :+1:

• when request is ready for re-review, please click "request review" or leave a comment; reviewer can't guess it by just seeing that some commits were pushed

[gavv]

Coverage: 92.687% (-1.4%) from 94.04% when pulling 0d77f4e on g41797:main into 9647d5d on roc-streaming:main.

I just noticed that the coverage was decreased:

• https://coveralls.io/builds/60211925/source?filename=roc%2Fsender.go
• https://coveralls.io/builds/60211925/source?filename=roc%2Freceiver.go

That's because the newly added error paths are not covered.

We need to add appropriate tests for sender and receiver.

[g41797]

[g41797]

roc/sender_receiver_test.go was deleted (see #97) but I didn't sync repos It's the reason of the conflict how to proceed?

[gavv]

roc/sender_receiver_test.go was deleted (see https://github.com/roc-streaming/roc-go/pull/97)

It was not deleted, it was renamed to e2e_test.go.

[gavv]

Note: there were no need to close PR and create a new one in this case; what you need, instead, is to fetch fresh main from upstream repo, rebase your forked branch on it, and force-push to your forked repo. PR will be automatically updated after force-push.

[g41797]

thanks saved in "how to ..."

On Mon, May 29, 2023 at 4:08 PM Victor Gaydov @.***> wrote:

Note: there were no need to close PR and create a new one in this case; what you need, instead, is to fetch fresh main from upstream repo, rebase your forked branch on it, and force-push to your forked repo. PR will be automatically updated after force-push.

— Reply to this email directly, view it on GitHub https://github.com/roc-streaming/roc-go/pull/94#issuecomment-1567121058, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACFRU6PINIOOQZBYAP7A2YDXISNWBANCNFSM6AAAAAAYJK2NWU . You are receiving this because you modified the open/close state.Message ID: @.***>