search

roc-streaming / roc-java

JNI bindings for Roc Toolkit.
https://roc-streaming.org
MIT License
21 stars 14 forks source link

Revise Android minSdkVersion #107

Closed gavv closed 3 weeks ago

gavv commented 1 year ago

Currently, Android minSdkVersion (i.e. Android API level which we support) is set to 26:

https://github.com/roc-streaming/roc-java/blob/b3096658ed7c7f34e42272d51d6d39f5bb38646c/android/roc-android/build.gradle#L26

We should check whether this value can be lowered or it is indeed minimum version we can work with.

Theoretically it could be lowered because the requirement of the underlying native library (libroc) is 21:

https://github.com/roc-streaming/roc-toolkit/blob/271ddf27eb3fae0273b5f8488a3114e70f1acfdb/SConstruct#LL720C35-L720C35

Chance are that roc-java has higher requirements than 21, but probably still lower than current 26. In this case, we'll need to update it in android/roc-android/build.gradle, scripts/android_docker.sh, and examples in README.md.

See also https://github.com/roc-streaming/roc-java/issues/105

gavv commented 3 weeks ago

Fixed via #132, docs added to README.

minSdkVersion is currently 29 (Android 10).