search

roc-streaming / roc-java

JNI bindings for Roc Toolkit.
https://roc-streaming.org
MIT License
21 stars 14 forks source link

remove getValue from Interface #117

Closed ortex closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #117 (3f9b487) into main (1685cdc) will decrease coverage by 0.06%. The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main     #117      +/-   ##
============================================
- Coverage     76.51%   76.45%   -0.06%     
+ Complexity       81       80       -1     
============================================
  Files            24       24              
  Lines           413      412       -1     
  Branches          2        2              
============================================
- Hits            316      315       -1     
  Misses           93       93              
  Partials          4        4
Impacted Files Coverage Δ
...in/java/org/rocstreaming/roctoolkit/Interface.java 100.00% <ø> (ø)
...in/java/org/rocstreaming/roctoolkit/RocSender.java 84.21% <50.00%> (ø)
.../java/org/rocstreaming/roctoolkit/RocReceiver.java 94.73% <100.00%> (ø)
gavv commented 1 year ago

LGTM. @ortex not merging because coverage failed, if that's OK (I guess), feel free to merge.