roc-streaming / roc-java

JNI bindings for Roc Toolkit.
https://roc-streaming.org
MIT License
21 stars 14 forks source link

fix multicast tests on android #91

Closed ortex closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #91 (de22a02) into main (c6642f7) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #91   +/-   ##
=========================================
  Coverage     70.89%   70.89%           
  Complexity       83       83           
=========================================
  Files            23       23           
  Lines           402      402           
  Branches          3        3           
=========================================
  Hits            285      285           
  Misses          110      110           
  Partials          7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gavv commented 1 year ago

There are actually two problems with multicast:

First is regression in roc-toolkit (https://github.com/roc-streaming/roc-toolkit/issues/532) - fixed and pushed to master.

Second is run-time problem on macOS android emulator that can be fixed using this:

adb shell "ip a" | grep 'state UP' | cut -d':' -f2 | awk '{print $1}' | cut -d'@' -f1 |
    while read iface
    do
        if ! adb shell ip route show table all | \
                grep -qF "224.0.0.0/4 dev ${iface} table local"
        then
            adb shell "su 0 ip route add 224.0.0.0/4 dev ${iface} table local"
        fi
    done
ortex commented 1 year ago

There are actually two problems with multicast:

First is regression in roc-toolkit (roc-streaming/roc-toolkit#532) - fixed and pushed to master.

Second is run-time problem on macOS android emulator that can be fixed using this:

adb shell "ip a" | grep 'state UP' | cut -d':' -f2 | awk '{print $1}' | cut -d'@' -f1 |
    while read iface
    do
        if ! adb shell ip route show table all | \
                grep -qF "224.0.0.0/4 dev ${iface} table local"
        then
            adb shell "su 0 ip route add 224.0.0.0/4 dev ${iface} table local"
        fi
    done

As I see we don't need the second part. CI Is green on main