search

roc-streaming / roc-pulse

Roc Toolkit modules for PulseAudio.
https://roc-streaming.org
GNU Lesser General Public License v2.1
8 stars 2 forks source link

roc_sender should quiesce UDP traffic when not playing audio #4

Open twojstaryzdomu opened 3 years ago

twojstaryzdomu commented 3 years ago

Currently, the roc_sender module is sending heavy UDP traffic whether the client is playing audio or not. It can impact the performance of the network when not playing anything and/or lead to unnecessary charges. That traffic is seen as redundant in the network, seeing as it does not lead to anything being played. Unless the sender module is unloaded manually, there is no way to stop the traffic. The redundant traffic precludes the use of roc over metered connections without prior access to the Pulseaudio load-module/unload-module commands, which is greatly impractical. Ideally, the sender should stop sending any data to the client as soon as playback is stopped.

gavv commented 3 years ago

Totally agree. This is a known problem though: roc-streaming/roc-pulse#22

gavv commented 2 years ago

To achieve this, roc_sender sink should handle suspend request from PulseAudio and stop sender. Accordingly, it should handle resume request from PulseAudio and restart sender.