Colored logs (#272) - Githubissues

roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.06k stars 213 forks source link

Closed kcy1019 closed 4 years ago

kcy1019 commented 5 years ago

screenshot

This PR adds colors to stderr logging while attached to a tty by adding:

--color=auto|never|always options to roc tools (roc_conv, roc_recv, roc_send)
roc::core::colors_available(), roc::core::format_colored(), roc::core::Logger::set_colors() functions See #272 for more details.

Thanks in advance for advices :)

gavv commented 5 years ago

Great! I'll take a look tomorrow.

dshil commented 5 years ago

Hi @kcy1019, thanks for the PR,

Could you please run scons -Q fmt to use the existing formatting style?

dshil commented 5 years ago

@kcy1019, I checked out to your branch, built roc and try to see colored logs but it seems that it doesn't work for me for some reason:

gavv commented 4 years ago

After fixing the last issues, could you please squash your commits? It may be a single commit or e.g. 3 commits (color functions, logger, tools).

gavv commented 4 years ago

LGTM!

dshil commented 4 years ago

@kcy1019, Thanks!

kcy1019 commented 4 years ago

@dshil @gavv Thank you for reviewing the patch. I really appreciate your thoughtful comments :)