Fixing roc_lib test fails under valgrind

roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.06k stars 213 forks source link

Closed alexandremgo closed 4 years ago

alexandremgo commented 4 years ago

Fix issue #223

I've relaxed the test requirements to have a certain percentage (for now 90%) of identical middle stream samples.

Should it raises a panic if a sample is not identical and is different from zero ?

gavv commented 4 years ago

Thanks for the PR! Will take a look today.

gavv commented 4 years ago

The code looks good!

Should it raises a panic if a sample is not identical and is different from zero ?

Yep. It would be a more correct check.

gavv commented 4 years ago

Also, I've done some testing and opened a new issue: #277.

gavv commented 4 years ago

Thanks!