Closed alexandremgo closed 4 years ago
The travis CI error comes from the macOS Xcode 10.2 config: https://travis-ci.org/roc-project/roc/jobs/615140615?utm_medium=notification&utm_source=github_status
[execute] ./configure --host= CXX=/usr/bin/clang++ CXXLD=/usr/bin/clang++ CC=/usr/bin/clang CCLD=/usr/bin/clang AR=/Applications/Xcode-10.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar RANLIB=/Applications/Xcode-10.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib CXXFLAGS="-fvisibility=hidden -I/Users/travis/build/roc-project/roc/3rdparty/x86_64-pc-apple-darwin18.5.0/clang-10.0.1-release/build/include -O2" CFLAGS="-fvisibility=hidden -I/Users/travis/build/roc-project/roc/3rdparty/x86_64-pc-apple-darwin18.5.0/clang-10.0.1-release/build/include -O2" LDFLAGS="-L/Users/travis/build/roc-project/roc/3rdparty/x86_64-pc-apple-darwin18.5.0/clang-10.0.1-release/build/lib" --enable-static --disable-shared --disable-openmp --without-id3tag --without-png --without-ao --without-opus
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated
@gavv can you relaunch the job please ? I think this error has nothing to do with my changes
Restarted. This happens from time to time with osx travis workers, unfortunately.
LGTM, thanks!
From comment https://github.com/roc-project/roc/pull/288#discussion_r348075405 Use
Array::grow_exp()
inStringList::grow()