search

roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.06k stars 213 forks source link

Employ build hooks in toolchain docker images #388

Closed gavv closed 3 years ago

gavv commented 4 years ago

We've recently merged a mechanism, based on docker build hooks, for building multiple variants of a single dockerfile and pushing them to multiple docker tags.

For details, see here:

It's currently used in env-android and toolchain-linux-android images.

We should use this new mechanism for other cross-compilation images:

Instead of duplicating dockerfiles for each tag and changing hard-coded parameters, we should use a single dockerfile for each image, parameterized using ARG mechanism, plus images.csv file which will be used by hooks to populate ARGs.

Dockerfiles are located here: https://github.com/roc-streaming/dockerfiles/tree/master/images

Documentation can be found here: https://roc-streaming.org/toolkit/docs/development/continuous_integration.html

jsomwaru commented 4 years ago

I'm interested in the project. Do you think I can take this issue?

gavv commented 4 years ago

@jsomwaru Sure, you're welcome.

jsomwaru commented 4 years ago

Would you like this done for other images as well instead of just the ones mentioned above? The Ubuntu images could also be managed the same way.

gavv commented 4 years ago

Dockerfiles for different ubuntu tags have different package sets, so I think using a single dockerfile wouldn't be beneficial here: it will anyway have conditions for each supported tag.

gavv commented 3 years ago

Thanks!