roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.06k stars 213 forks source link

add Android APIs 24, 26 and 29 #404

Closed MatteoArella closed 4 years ago

MatteoArella commented 4 years ago

This PR would close #390.

gavv commented 4 years ago

Android job now takes 42 minutes, and it'll become even longer after we'll add tests. I suggest to remove API 26 (Android 8), so that we'll test three versions: two latest widely used versions (currently 9 and 10), and the oldest supported version (currently 7).

I hope this will reduce the time below 30 minutes. However after adding tests it may become too long again. In this case we may try to split the job or speed it up by caching downloaded content between builds.

gavv commented 4 years ago

or speed it up by caching downloaded content between builds

I've created a new issue for that: #405.

gavv commented 4 years ago

Related: #406.

gavv commented 4 years ago

LGTM! Oh, and thanks for fixing the variables prefix.