search

roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.06k stars 213 forks source link

updated interface for IReader #438

Closed bkayes closed 2 years ago

bkayes commented 3 years ago

Initial work for Issue: #302

gavv commented 3 years ago

Thanks for PR!

As far as I can tell, it's not ready for review yet, right? Since it mostly doesn't try to handle partial and failed reads and doesn't update return statements in many methods?

BTW note that we need separate error code for EOF.

github-actions[bot] commented 3 years ago

:umbrella: The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts.

gavv commented 2 years ago

Closing this for now, feel free to reopen if you'll have a chance to continue work.