roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.06k stars 213 forks source link

Don't define _POSIX_C_SOURCE for FreeBSD #463

Closed jdeblese closed 2 years ago

jdeblese commented 2 years ago

Under FreeBSD, defining _POSIX_C_SOURCE causes __BSD_VISIBLE, __XSI_VISIBLE, __POSIX_VISIBLE, and _POSIX_SOURCE to be set such that various important bits are not available. This includes the macros IN_MULTICAST, MSG_DONTWAIT, and M_PI, and the struct sigaction. The FreeBSD man page standards(5) describes this in much detail, but what it comes down to is that for relatively normal code that macro shouldn't be defined at all.

Seems plausible that this applies to Net and OpenBSD as well, but TBD.

gavv commented 2 years ago

Thank you!