search

roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.03k stars 205 forks source link

Handle situation when ParseCompilerVersion returns None #479

Closed tallero closed 1 year ago

tallero commented 1 year ago

The function ParseCompilerVersion in site_scons/site_tools/roc/parsers.py should never return None or the corresponding code in /SConstruct should be adapted to take that into consideration.

gavv commented 1 year ago

Hi, thanks for report.

Do you have specific use case when this problem arises?

tallero commented 1 year ago

I remember this issue arose while building the aur packages.

gavv commented 1 year ago

I see.

We'll need to adjust SConstruct to handle the case when ParseCompilerVersion() was not able to detect compiler version. This is a valid case.

gavv commented 1 year ago

Actually, I checked current scripts, and everywhere where we call ParseCompilerVersion, we check its return value and either report error or handle it some other way.

So most likely the issue is not relevant in 0.2.x, and I'm going to close it with "can't reproduce".

However feel free to reopen if you will experience it again or will be able to reproduce. Thanks.