search

roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.06k stars 213 forks source link

Error handling for invalid compiler version #492

Closed june34876 closed 1 year ago

june34876 commented 1 year ago

Disabling return none for ParseCompilerVersion function in parsers.py

gavv commented 1 year ago
  1. We're usually not throwing exceptions from scons helpers, returning None is a common way to report failure.
  2. Just throwing exception without handling it makes no sense. As you can see, this patch broke many CI steps.
  3. Not being able to determine compiler version is a possible situation. We should not fail, we should just handle it correctly in SConstruct.