roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.03k stars 205 forks source link

Added version-check to CI #543

Closed dheerajd5 closed 10 months ago

dheerajd5 commented 10 months ago

This PR adds a version-check to CI checks. It takes the version fetched from git and from the file version.h and compares it.

497

gavv commented 10 months ago

Thanks for PR! Will review it in upcoming days.

dheerajd5 commented 10 months ago

Hey, I rebased over existing commits by mistake, I'll put up a new PR with the code reviewed changes.

adrianopol commented 10 months ago

Hi, there is no need to close this one, you may just fix your branch locally (e.g. rebase on roc-streaming:develop branch) and then make git push -f.

dheerajd5 commented 10 months ago

Oh, sorry I'm new to this, I'll keep it in mind next time.

adrianopol commented 10 months ago

no problem, thank you!