Closed dshil closed 9 months ago
:umbrella: The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts.
Hi @gavv, thanks for your comments. I've updated the PR. When you will be ready to accept these changes, please ping me and I'll link the task.
Huge work.
This PR implements new behavior for which we need new tests.
We should add tests how some readers handle ErrNoData and other errors returned from underlying readers.
The following classes should be covered:
Group 1:
These classes forward any error as-is.
Group 2:
These classes have special handling for ErrNoData and forward other errors.
Group 3:
This class does not forward any error (for now), but should correctly work with any error.
Could you please either add these tests (in this or separate PR), or create an issue describing what tests to add?
303