roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.03k stars 205 forks source link

GH-303 Add support for status codes in packet reader #570

Closed dshil closed 9 months ago

dshil commented 9 months ago

303

github-actions[bot] commented 9 months ago

:umbrella: The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts.

dshil commented 9 months ago

Hi @gavv, thanks for your comments. I've updated the PR. When you will be ready to accept these changes, please ping me and I'll link the task.

gavv commented 9 months ago

Huge work.

This PR implements new behavior for which we need new tests.

We should add tests how some readers handle ErrNoData and other errors returned from underlying readers.

The following classes should be covered:

Group 1:

Group 2:

Group 3:

Could you please either add these tests (in this or separate PR), or create an issue describing what tests to add?