roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.06k stars 211 forks source link

Follow up for #549 #623

Closed baranovmv closed 10 months ago

baranovmv commented 11 months ago

539

From #549:

In receiver_source test recv_timestamp_mapping_remixing the failure was caused by the issue in Depacketizer. As you suggested (after my localization): https://github.com/roc-streaming/roc-toolkit/issues/539#issuecomment-1712284093:

We should check if Depacketizer correctly handles case when first packet for frame had zero CTS, and second packet for the same frame had non-zero CTS.

I think it's not covered right now.

We need a test for this and maybe a fix.

In sender_sink tests the issue is simple: Resampler backend throw away first n samples (N==latency), which was not properly reflected in test::PacketReader

github-actions[bot] commented 11 months ago

:umbrella: The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts.

github-actions[bot] commented 10 months ago

:robot: The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.

github-actions[bot] commented 10 months ago

:robot: The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.

github-actions[bot] commented 10 months ago

:robot: The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.

gavv commented 10 months ago

I'm preparing 0.3.0 release and have rebased develop on master, please rebase PR.

I also cherry-picked depacketizer fix from this PR to develop (without tests) to make it part of the release: 55821da629f43d729928c5444d74d3deda73afb9

gavv commented 10 months ago

Thanks!