search

roc-streaming / roc-toolkit

Real-time audio streaming over the network.
https://roc-streaming.org
Mozilla Public License 2.0
1.02k stars 203 forks source link

print_supported implemented for recv and send tools. #642

Closed Hrick87 closed 7 months ago

Hrick87 commented 7 months ago

Issue #578

I am uncertain if the consolidated interface enumeration and its corresponding protocol should be a part of the printed list, but otherwise I believe I've done this all correctly.

gavv commented 7 months ago

I am uncertain if the consolidated interface enumeration and its corresponding protocol should be a part of the printed list, but otherwise I believe I've done this all correctly.

Yep, consolidated should be included.

gavv commented 7 months ago

Thanks for update, LGTM!

BTW, please don't resolve discussions by yourself, keep them for reviewer, otherwise it's hard to track what is needed to be re-reviewed. Instead you can add comment or :+1: on discussion to indicate that it was addressed.

Hrick87 commented 7 months ago

Thanks for update, LGTM!

BTW, please don't resolve discussions by yourself, keep them for reviewer, otherwise it's hard to track what is needed to be re-reviewed. Instead you can add comment or 👍 on discussion to indicate that it was addressed.

Ah my mistake, understood. I'll stick to using comments/thumbs up instead. I thought the resolve something each of us did individually on our own ends.