Implemented WAV source, sink and backend

roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.02k stars 203 forks source link

Implemented WAV source, sink and backend #659

Closed Pekureda closed 5 months ago

Pekureda commented 6 months ago

Implemented issue: 576

Implemented source, sink and backend for WAV file read and write operation handling,
Added dr_wav single header library,
Read operations of WAV files are performed using dr_wav,
Implemented WavHeader to store and handle headers of written WAV files,
Changed lib download links from ftp to https based.

github-actions[bot] commented 6 months ago

:robot: Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

gavv commented 6 months ago

Thanks for PR! Will review in upcoming days!

Pekureda commented 6 months ago

Thanks for detailed review and finding all those issues! I've updated the commit and fixed mentioned problems.

gavv commented 6 months ago

Thanks,

It seems you forgot to commit your changes or pushed a wrong commit?

Seems that the new cimmit is identical to the old one.

https://github.com/roc-streaming/roc-toolkit/compare/155d58f67566a3a8c2833059268dc80572743a1b..d7378fa820baea482d65ae5afd9242532cca1e3a

gavv commented 6 months ago

Hi, I've pushed commit 03d29eb97211ca87593566998c5087590c1bae38 to develop branch that adds new fields sample_format and pcm_format to SampleSpec.

It mostly does not affect this PR, but SampleSpec ctor now has new parameter pcm_format, which you can just set to audio::Sample_RawFormat (which means that source/sink produces/consumes samples in "raw" format - 32-bit PCM floats).

So please rebase on fresh develop.

Pekureda commented 6 months ago

It's rebased and adjusted to newest changes on develop branch. I must've not force pushed the amended commit and not noticed that.

gavv commented 5 months ago

Thanks, looks and works great!

I've pushed a small follow-up commit: fc0fab2785e1349e731d0d06c9e3535ba223b7d7

Changes:

Array::grow() call is now not needed
In WavSink, if channels or rate is not specified, use default values (otherwise roc-send panics)
In WavSource, ignore sample_spec from config (we don't and can't use it because we can't do any conversions)
Use Sample_RawFormat instead of PcmFormat_Float32_Le when reporting sample spec. Sample_RawFormat corresponds to format of sample_t type. It's equal to PcmFormat_Float32_Le only on little-endian machines, but it's PcmFormat_Float32_Be on big-endian ones.

gavv commented 5 months ago

We also forgot one small thing, I've created a new issue for it: https://github.com/roc-streaming/roc-toolkit/issues/684