roc-streaming / roc-toolkit

Real-time audio streaming over the network.

https://roc-streaming.org

Mozilla Public License 2.0

1.02k stars 203 forks source link

Seqlock implementation extract #664

Closed nolan-veed closed 6 months ago

nolan-veed commented 6 months ago

Why

For https://github.com/roc-streaming/roc-toolkit/issues/599

What

Created a SeqlockImpl class and used it in SeqLock.

Testing

There are tests.

github-actions[bot] commented 6 months ago

:robot: Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats.

nolan-veed commented 6 months ago

For some reason, my tests are hanging here...

nolan-veed commented 6 months ago

For some reason, my tests are hanging here...

Oh wait... the Timer is using Seqlock, so it's clearly uncovered a bug in my change.

gavv commented 6 months ago

Thanks!

Small refactoring: 3ebb8c86f5797b6d23dced13f28b18966412600d (see commit message for details)